-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding validated, approved CellGuide patterns #2530
Conversation
Some background - we promised to review and potentially integrate these definitions as part of our work for CZI. I think that there is enough useful content that it is worth folding this into CL. I also think it is helpful for editor to be able to see these descriptions in the file while editing, as they often have useful additional content for definitions and links to CL. Here is an example of added content. Please review the boilerplate disclaimer text (this is from the DOSDP added by this PR) (Note - these definitions will not be visible in cl-edit.owl until we run a release or we run the DOSDP build locally) |
Thanks for letting me know, David. I was checking if there was a consensus for adding them on the CL call (18/10/2023), but there was not. I am in favor to add them, and I am happy with the inclusion as a description with the disclaimer message. My only question is if this will be visualized in OLS. |
CC @Caroline-99 |
All AP axioms show up in OLS. If they're not part of the OBO core fields, they show up in the column on the right hand side. |
I vote to add them, since it includes only curated definitions. |
Hi @hkir-dev - I think this PR may have an a definitions.owl with all the CellGuide descriptions in whereas ExtendedDescriptions.tsv now only has reviewed. Could you rebuild definitions.owl again so we can merge? |
It seems that |
Done. (I'd forgotten that clashing definitions.owl builds were getting in the way of me pushing. Cleaned up now) |
definitions.owl updated |
Fixes #2081 #2350
Tested locally & results look good in Protege.
Probably some more plumbing work needed to get this running automagically?