Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding validated, approved CellGuide patterns #2530

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Conversation

dosumis
Copy link
Contributor

@dosumis dosumis commented Aug 30, 2024

Fixes #2081 #2350

Tested locally & results look good in Protege.

Probably some more plumbing work needed to get this running automagically?

hkir-dev
hkir-dev previously approved these changes Aug 30, 2024
@dosumis dosumis requested a review from aleixpuigb August 30, 2024 13:22
@dosumis
Copy link
Contributor Author

dosumis commented Aug 30, 2024

@aleixpuigb

Some background - we promised to review and potentially integrate these definitions as part of our work for CZI. I think that there is enough useful content that it is worth folding this into CL. I also think it is helpful for editor to be able to see these descriptions in the file while editing, as they often have useful additional content for definitions and links to CL.

Here is an example of added content. Please review the boilerplate disclaimer text (this is from the DOSDP added by this PR)

image
image

(Note - these definitions will not be visible in cl-edit.owl until we run a release or we run the DOSDP build locally)

@aleixpuigb
Copy link
Collaborator

Thanks for letting me know, David. I was checking if there was a consensus for adding them on the CL call (18/10/2023), but there was not. I am in favor to add them, and I am happy with the inclusion as a description with the disclaimer message. My only question is if this will be visualized in OLS.

@dosumis
Copy link
Contributor Author

dosumis commented Aug 30, 2024

CC @Caroline-99

@dosumis
Copy link
Contributor Author

dosumis commented Aug 30, 2024

My only question is if this will be visualized in OLS.

All AP axioms show up in OLS. If they're not part of the OBO core fields, they show up in the column on the right hand side.

@aleixpuigb
Copy link
Collaborator

I vote to add them, since it includes only curated definitions.

aleixpuigb
aleixpuigb previously approved these changes Aug 30, 2024
@dosumis
Copy link
Contributor Author

dosumis commented Sep 6, 2024

Hi @hkir-dev - I think this PR may have an a definitions.owl with all the CellGuide descriptions in whereas ExtendedDescriptions.tsv now only has reviewed. Could you rebuild definitions.owl again so we can merge?
Thanks!

@hkir-dev
Copy link
Contributor

hkir-dev commented Sep 6, 2024

It seems that ExtendedDescription.tsv haven't changed since the last build (last edit is 30 August). Can you commit your changes?

@dosumis dosumis dismissed stale reviews from aleixpuigb and hkir-dev via 4b18655 September 6, 2024 16:16
@dosumis
Copy link
Contributor Author

dosumis commented Sep 6, 2024

It seems that ExtendedDescription.tsv haven't changed since the last build (last edit is 30 August). Can you commit your changes?

Done. (I'd forgotten that clashing definitions.owl builds were getting in the way of me pushing. Cleaned up now)

@hkir-dev
Copy link
Contributor

hkir-dev commented Sep 9, 2024

definitions.owl updated

@dosumis dosumis merged commit 835fd22 into master Sep 9, 2024
1 check passed
@dosumis dosumis deleted the cellguide_defs branch September 9, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using LLM outputs to enhance CL terms and structure
3 participants