Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2774 - Added GO links to deuterosomal cell #2777

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

Caroline-99
Copy link
Collaborator

Imported and added a GO term to deuterosomal cell

Imported and added a GO term to deuterosomal cell
@Caroline-99 Caroline-99 linked an issue Nov 19, 2024 that may be closed by this pull request
@Caroline-99 Caroline-99 self-assigned this Nov 19, 2024
dosumis
dosumis previously approved these changes Nov 19, 2024
Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Any idea why the mapping files also changed?

@dosumis
Copy link
Contributor

dosumis commented Nov 19, 2024

GO update seems to have pulled in an obsolete term

label: hepatocyte
relationship: capable_of GO:0044237 ! obsolete cellular metabolic process

This is way too general to be useful so I'd just delete. (I'm sure there are many more specific metabolic processes we could link to, but that may be a bit of a rabbit hole)

@Caroline-99
Copy link
Collaborator Author

GO update seems to have pulled in an obsolete term

label: hepatocyte
relationship: capable_of GO:0044237 ! obsolete cellular metabolic process

This is way too general to be useful so I'd just delete. (I'm sure there are many more specific metabolic processes we could link to, but that may be a bit of a rabbit hole)

will delete it now

Deleted obsoleted GO term cellular metabolic process link to hepatocyte
Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits look good.

May not be an issue, but still wondering why there is an update to mapping file format @gouttegd - is this from some update of yours? Could it be coupled to running the import update?

@gouttegd
Copy link
Collaborator

@dosumis

Could it be coupled to running the import update?

Yes. Refreshing the imports (e.g. with make refresh-imports) has the side-effects of also refreshing the externally maintained mapping sets.

@Caroline-99 Caroline-99 merged commit 297097c into master Nov 19, 2024
1 check passed
@Caroline-99 Caroline-99 deleted the 2774-link-deuterosomal-cell-to-GO branch November 19, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link deuterosomal cell to centriole replication
3 participants