Demonstrate using TAXRANK for ranks and properties #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
requested changes
Nov 27, 2024
There was a problem hiding this comment.
I personally very much like this change, and I approve of it, but I will request changes so that it is not accidentally merged before I can get some community feedback (and we can use my disapproval as a blocker until the taxrank PR is released).
Thank you very much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96, closes #97
This PR demonstrates switching to using external TAXRANK identifiers rather than ad-hoc ones in the NCBITaxon space.
It depends on phenoscape/taxrank#5, where I added the remaining 12 ranks that weren't already represented, including "strain", which was the point of discussion also in #17