Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OMO for synonym type predicates #88

Merged
merged 12 commits into from
Nov 7, 2023
Merged

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Sep 23, 2023

Closes #87

This PR updates the RDF generation to use OMO terms, when available. It extends the predicates configuration dictionary at the top so that new OMO terms can be added in as they are minted. Currently, this PR switches 4 terms to using OMO:

Existing IRI New OMO IRI
http://purl.obolibrary.org/obo/ncbitaxon#acronym http://purl.obolibrary.org/obo/OMO_0003012
http://purl.obolibrary.org/obo/ncbitaxon#common_name http://purl.obolibrary.org/obo/OMO_0003003
http://purl.obolibrary.org/obo/ncbitaxon#misnomer http://purl.obolibrary.org/obo/OMO_0003007
http://purl.obolibrary.org/obo/ncbitaxon#misspelling http://purl.obolibrary.org/obo/OMO_0003006

There will have to be more detailed follow-up discussion if we want to complete the coverage of OMO on these synonyms.

@cthoyt cthoyt changed the title Begin using OMO for synonym type predicates Use OMO for synonym type predicates Sep 25, 2023
Copy link
Collaborator

@jamesaoverton jamesaoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run the code, but it looks good.

This is a breaking change for some of my workflows, which filter on the CURIE of the synonym type. The notes for the next release should be clear about the possible breakage. It might also be good to announce this release on OBO Discuss (which we don't bother doing for most releases), or mention it in any announcements about the large OMO synonym migration.

@cmungall
Copy link
Member

I think that's a good idea @jamesaoverton

@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 26, 2023

I can make that announcement if you'd like. I would also include some more context about how we are working towards standardizing synoynms across other ontologies too, and similar things might pop up in the near future.

Edit: see the announcement

src/ncbitaxon.py Outdated Show resolved Hide resolved
@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 16, 2023

hi @anitacaron, is there anything else you'd like me to take care of to finish this PR? The OMO definitions now have the correct labels like in

OMO:0003000 a owl:AnnotationProperty ;
    rdfs:label "abbreviation"^^xsd:string ;
    oboInOwl:hasScope "oio:hasBroadSynonym"^^xsd:string ;
    rdfs:subPropertyOf oboInOwl:SynonymTypeProperty .

@anitacaron
Copy link
Contributor

I'm still not sure about this axiom that is added to the OMO:0003000: oboInOwl:hasScope "oio:hasBroadSynonym"^^xsd:string ;

@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 16, 2023

@anitacaron I also saw that and think there's something fishy, but I didn't want to make any changes to the existing functionality. I'm happy to make a second PR that makes this a proper reference to a IRI instead of a string if you think that will make assessing this PR easier

@anitacaron
Copy link
Contributor

This axiom is added to the other annotations, original from NCBITaxon. Now, adding OMO as annotations should not include this.

@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 16, 2023

So for OMO definitions it shouldn't have the scope added?

@anitacaron
Copy link
Contributor

I think so. Someone else could confirm.

@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 17, 2023

I think so. Someone else could confirm.

I removed the scope statement from OMO terms in 7f9fb51

src/ncbitaxon.py Show resolved Hide resolved
src/ncbitaxon.py Outdated Show resolved Hide resolved
@cthoyt cthoyt mentioned this pull request Oct 18, 2023
@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 23, 2023

@anitacaron would you please merge this? I think we're ready for a release, too.

@anitacaron anitacaron merged commit 9b2748e into obophenotype:master Nov 7, 2023
@cthoyt cthoyt deleted the patch-1 branch November 7, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use OMO terms for synonym types
5 participants