Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stomatogastric ganglion crab lobster #3445

Conversation

stevewds
Copy link
Contributor

Hi -

Here we add parts of the stomatogastric nervous system of crabs and lobsters.

  1. We added a new "stomatogastric nervous system" term to cover both crabs and lobsters and insects. We updated the old term "insect stomatogastric nervous system" to be "part of" the stomatogastric nervous system.

  2. We added some 14 parts of the stomatogastric nervous system of crabs and lobsters.

We discussed these changes at the November Uberon meeting.

Thanks
Dre and Steve

@stevewds
Copy link
Contributor Author

Requesting @rays22 as a reviewer as discussed in the November meeting.

Best wishes
Steve

Copy link
Collaborator

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need add your terms by editing the file uberon/src/ontology/uderon-edit.obo. The uberon.obo file will be automatically updated at the time of the next public release of Uberon. (FYI: The documentation incorrectly states that you edit the uberon-edit.owl file.)
Actions:

  1. Undo your changes to uberon.obo.
  2. Add your new terms to uberon/src/ontology/uderon-edit.obo.
  3. I am not sure if the part_of relationships that you used is appropriate for the relationship between and the insect stomatogastric nervous system and the new stomatogastric nervous system. I think it should be a sub-class (is_a) relationship, i.e. the insect stomatogastric nervous system is_a stomatogastic nervous system.
id: UBERON:6005096
name: insect stomatogastric nervous system
...
relationship: part_of UBERON:8910000 ! stomatogastic nervous system

@stevevanhooser
Copy link
Contributor

Thanks @rays22, revised as requested

Best
Steve

Copy link
Collaborator

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several non-standard characters in the uberon-edit.obo file. Please, remove them.
I would like to check the inferred relationships between the existing and the newly added terms, but Protege fails to open uberon-edit.obo from this github branch.
The error message in Protege is org.xml.sax.SAXParseException. Could the failure of Protege to parse uberon-edit.obo be related to the non-standard characters in the file?

src/ontology/uberon-edit.obo Show resolved Hide resolved
src/ontology/uberon-edit.obo Show resolved Hide resolved
src/ontology/uberon-edit.obo Show resolved Hide resolved
src/ontology/uberon-edit.obo Show resolved Hide resolved
src/ontology/uberon-edit.obo Show resolved Hide resolved
@stevevanhooser
Copy link
Contributor

@rays22 , sorry for that, I think I have removed them all. (I don't have a "special character detector" program but I saw the ones above.)

Copy link
Collaborator

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Fix the syntax for SubClass assertion (and typo in label).
    id: UBERON:6005096
    ...
    -relationship: is_a UBERON:8910000 ! stomatogastic nervous system
  • correctly:
is_a: UBERON:8910000 ! stomatogastric nervous system

Fix syntax for SubClass assertion.

  1. Use unique IDs. UBERON:8910013 has been used twice.

  2. Fix "synonym" syntax (at several places).

e.g.

from synonym: "STG" to

synonym: "STG" EXACT []

src/ontology/uberon-edit.obo Show resolved Hide resolved
src/ontology/uberon-edit.obo Show resolved Hide resolved
src/ontology/uberon-edit.obo Show resolved Hide resolved
@stevevanhooser
Copy link
Contributor

Thanks @rays22, fixed and updated

@stevevanhooser
Copy link
Contributor

Thanks @rays22 .

I'm a little confused. I've opened this in protoge, and I see it as a subclass, but I may not be viewing it the same way that you are. Sorry for my newbie issues!

Here if I'm looking at insect stomatogastric nervous system in Protoge it says it "is a some stomatogastric nervous system"

Screenshot 2024-12-17 at 1 39 23 PM

@rays22
Copy link
Collaborator

rays22 commented Dec 18, 2024

Thanks @rays22 .

I'm a little confused. I've opened this in protoge, and I see it as a subclass, but I may not be viewing it the same way that you are. Sorry for my newbie issues!

Here if I'm looking at insect stomatogastric nervous system in Protoge it says it "is a some stomatogastric nervous system"

Screenshot 2024-12-17 at 1 39 23 PM

It should look like this:
subClassOf-somatogastric_nervous_system

  1. The insect somatogastric nervous system should be a branch of the somatogastrcic nervous system in the Class Hierarchy (left arrow).
  2. The is_a some 'somatogastric nervous system' is a slightly but significantly different axiom from what we want here (right arrow).

@stevevanhooser
Copy link
Contributor

Thanks Ray. Do you know how I should fix it? I'm not sure which language the .obo file is.

@rays22
Copy link
Collaborator

rays22 commented Dec 18, 2024

Thanks Ray. Do you know how I should fix it? I'm not sure which language the .obo file is.

You can replace line 219797 with my suggested fix. (You might be able to apply the suggested change directly here in the PR .

https://github.com/obophenotype/uberon/pull/3445/files#r1889024567

@stevevanhooser
Copy link
Contributor

Ah, got it. Sorry, I didn't realize the word "relationship" messed it all up. It's now fixed and looks the same for me as it does for you in Protoge

Thanks
Steve

Copy link
Collaborator

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have some more (hopefully final) comments. We are getting there ... 😃

src/ontology/uberon-edit.obo Show resolved Hide resolved
Comment on lines 224792 to 224793
relationship: part_of UBERON:8910000 ! stomatogastric nervous system
relationship: part_of UBERON:8910001 ! stomatogastric ganglion
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
relationship: part_of UBERON:8910000 ! stomatogastric nervous system
relationship: part_of UBERON:8910001 ! stomatogastric ganglion
relationship: part_of UBERON:8910001 ! stomatogastric ganglion

Keep only one of the two axioms.

  • Explanation:
    If the stomatogastric ganglion is part of the stomatogastric nervous system, and another anatomical entity is part of the stomatogastric ganglion, then it is redundant to assert that the anatomical entity is also part of the stomatogastric nervous system. (The part of relationship is transitive.) Multiple classifications chains resulting from redundant assertions make the ontology difficult to edit and maintain in the long run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting question we should unpack further. Many of these nerves are partially comprised of processes that originate from the stomatogastric ganglion, but then they extend far outside the ganglion around other parts of the stomatogastric nervous system. If you cut out the stomatogastric ganglion, many of these processes would still be there and would still be part of the stomatogastric nervous system.

Is there a different way we should capture the relationship?

This comment is similar for the other cases...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting question we should unpack further. Many of these nerves are partially comprised of processes that originate from the stomatogastric ganglion, but then they extend far outside the ganglion around other parts of the stomatogastric nervous system. If you cut out the stomatogastric ganglion, many of these processes would still be there and would still be part of the stomatogastric nervous system.

Is there a different way we should capture the relationship?

This comment is similar for the other cases...

I see. There is the RO:0002131 overlaps relationship that might capture this.

Comment on lines 224803 to 224804
relationship: part_of UBERON:8910000 ! stomatogastric nervous system
relationship: part_of UBERON:8910001 ! stomatogastric ganglion
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
relationship: part_of UBERON:8910000 ! stomatogastric nervous system
relationship: part_of UBERON:8910001 ! stomatogastric ganglion
relationship: part_of UBERON:8910001 ! stomatogastric ganglion

Comment on lines 224814 to 224815
relationship: part_of UBERON:8910000 ! stomatogastric nervous system
relationship: part_of UBERON:8910001 ! stomatogastric ganglion
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
relationship: part_of UBERON:8910000 ! stomatogastric nervous system
relationship: part_of UBERON:8910001 ! stomatogastric ganglion
relationship: part_of UBERON:8910001 ! stomatogastric ganglion

@stevevanhooser
Copy link
Contributor

Yes, overlaps works. Changed!

Copy link
Collaborator

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rays22 rays22 merged commit d4c42ac into obophenotype:master Dec 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants