-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stomatogastric ganglion crab lobster #3445
Stomatogastric ganglion crab lobster #3445
Conversation
Requesting @rays22 as a reviewer as discussed in the November meeting. Best wishes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need add your terms by editing the file uberon/src/ontology/uderon-edit.obo
. The uberon.obo
file will be automatically updated at the time of the next public release of Uberon. (FYI: The documentation incorrectly states that you edit the uberon-edit.owl
file.)
Actions:
- Undo your changes to
uberon.obo
. - Add your new terms to
uberon/src/ontology/uderon-edit.obo
. - I am not sure if the
part_of
relationships that you used is appropriate for the relationship between and theinsect stomatogastric nervous system
and the newstomatogastric nervous system
. I think it should be a sub-class (is_a
) relationship, i.e. theinsect stomatogastric nervous system
is_astomatogastic nervous system
.
id: UBERON:6005096
name: insect stomatogastric nervous system
...
relationship: part_of UBERON:8910000 ! stomatogastic nervous system
Thanks @rays22, revised as requested Best |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several non-standard characters in the uberon-edit.obo
file. Please, remove them.
I would like to check the inferred relationships between the existing and the newly added terms, but Protege fails to open uberon-edit.obo
from this github branch.
The error message in Protege is org.xml.sax.SAXParseException
. Could the failure of Protege to parse uberon-edit.obo
be related to the non-standard characters in the file?
….com/Waltham-Data-Science/uberon into stomatogastric_ganglion_crab_lobster
@rays22 , sorry for that, I think I have removed them all. (I don't have a "special character detector" program but I saw the ones above.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix the syntax for SubClass assertion (and typo in label).
id: UBERON:6005096
...
-relationship: is_a UBERON:8910000 ! stomatogastic nervous system
- correctly:
is_a: UBERON:8910000 ! stomatogastric nervous system
Fix syntax for SubClass assertion.
-
Use unique IDs. UBERON:8910013 has been used twice.
-
Fix "synonym" syntax (at several places).
e.g.
from synonym: "STG"
to
synonym: "STG" EXACT []
Thanks @rays22, fixed and updated |
Thanks @rays22 . I'm a little confused. I've opened this in protoge, and I see it as a subclass, but I may not be viewing it the same way that you are. Sorry for my newbie issues! Here if I'm looking at insect stomatogastric nervous system in Protoge it says it "is a some stomatogastric nervous system" |
|
Thanks Ray. Do you know how I should fix it? I'm not sure which language the .obo file is. |
You can replace line 219797 with my suggested fix. (You might be able to apply the suggested change directly here in the PR . https://github.com/obophenotype/uberon/pull/3445/files#r1889024567 |
Ah, got it. Sorry, I didn't realize the word "relationship" messed it all up. It's now fixed and looks the same for me as it does for you in Protoge Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I have some more (hopefully final) comments. We are getting there ... 😃
src/ontology/uberon-edit.obo
Outdated
relationship: part_of UBERON:8910000 ! stomatogastric nervous system | ||
relationship: part_of UBERON:8910001 ! stomatogastric ganglion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relationship: part_of UBERON:8910000 ! stomatogastric nervous system | |
relationship: part_of UBERON:8910001 ! stomatogastric ganglion | |
relationship: part_of UBERON:8910001 ! stomatogastric ganglion |
Keep only one of the two axioms.
- Explanation:
If thestomatogastric ganglion
is part of thestomatogastric nervous system
, and another anatomical entity is part of thestomatogastric ganglion
, then it is redundant to assert that the anatomical entity is also part of thestomatogastric nervous system
. (Thepart of
relationship is transitive.) Multiple classifications chains resulting from redundant assertions make the ontology difficult to edit and maintain in the long run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting question we should unpack further. Many of these nerves are partially comprised of processes that originate from the stomatogastric ganglion, but then they extend far outside the ganglion around other parts of the stomatogastric nervous system. If you cut out the stomatogastric ganglion, many of these processes would still be there and would still be part of the stomatogastric nervous system.
Is there a different way we should capture the relationship?
This comment is similar for the other cases...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting question we should unpack further. Many of these nerves are partially comprised of processes that originate from the stomatogastric ganglion, but then they extend far outside the ganglion around other parts of the stomatogastric nervous system. If you cut out the stomatogastric ganglion, many of these processes would still be there and would still be part of the stomatogastric nervous system.
Is there a different way we should capture the relationship?
This comment is similar for the other cases...
I see. There is the RO:0002131 overlaps relationship that might capture this.
src/ontology/uberon-edit.obo
Outdated
relationship: part_of UBERON:8910000 ! stomatogastric nervous system | ||
relationship: part_of UBERON:8910001 ! stomatogastric ganglion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relationship: part_of UBERON:8910000 ! stomatogastric nervous system | |
relationship: part_of UBERON:8910001 ! stomatogastric ganglion | |
relationship: part_of UBERON:8910001 ! stomatogastric ganglion |
src/ontology/uberon-edit.obo
Outdated
relationship: part_of UBERON:8910000 ! stomatogastric nervous system | ||
relationship: part_of UBERON:8910001 ! stomatogastric ganglion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relationship: part_of UBERON:8910000 ! stomatogastric nervous system | |
relationship: part_of UBERON:8910001 ! stomatogastric ganglion | |
relationship: part_of UBERON:8910001 ! stomatogastric ganglion |
Yes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Hi -
Here we add parts of the stomatogastric nervous system of crabs and lobsters.
We added a new "stomatogastric nervous system" term to cover both crabs and lobsters and insects. We updated the old term "insect stomatogastric nervous system" to be "part of" the stomatogastric nervous system.
We added some 14 parts of the stomatogastric nervous system of crabs and lobsters.
We discussed these changes at the November Uberon meeting.
Thanks
Dre and Steve