Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stomatogastric ganglion crab lobster #3445
Stomatogastric ganglion crab lobster #3445
Changes from 8 commits
6ba77a5
3d796fd
ba77a5d
45eea71
083d922
34b032e
a365958
80c52e9
2eaf985
e97f859
82772a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep only one of the two axioms.
If the
stomatogastric ganglion
is part of thestomatogastric nervous system
, and another anatomical entity is part of thestomatogastric ganglion
, then it is redundant to assert that the anatomical entity is also part of thestomatogastric nervous system
. (Thepart of
relationship is transitive.) Multiple classifications chains resulting from redundant assertions make the ontology difficult to edit and maintain in the long run.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting question we should unpack further. Many of these nerves are partially comprised of processes that originate from the stomatogastric ganglion, but then they extend far outside the ganglion around other parts of the stomatogastric nervous system. If you cut out the stomatogastric ganglion, many of these processes would still be there and would still be part of the stomatogastric nervous system.
Is there a different way we should capture the relationship?
This comment is similar for the other cases...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. There is the RO:0002131 overlaps relationship that might capture this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.