Remove injections about RO:has_skeleton. #3416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RO, 'has skeleton' (RO:0002551) is domain-restricted to 'anatomical structure' (UBERON:0000061) and range-restricted to 'material anatomical entity' (UBERON:0000465). Currently, in Uberon we are overriding those restrictions by injecting tigher constraints: a domain restriction to 'organism subdivision' (UBERON:0000475) and a range restriction to 'subdivision of skeleton' (UBERON:0010912). A ticket to upstream those tighter restrictions to RO has gone nowhere in more than one year (oborel/obo-relations#700). This PR removes the Uberon-injected restrictions and leaves it to RO to decide whether they should adopt them or not. Of note, the only inferred axiom that those tighter restrictions give us is this one: > 'nose' SubClassOf: 'organism subdivision' So we don't lose much by removing them until they are (maybe) added back directly by RO. Related to #2453
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RO, 'has skeleton' (RO:0002551) is domain-restricted to 'anatomical structure' (UBERON:0000061) and range-restricted to 'material anatomical entity' (UBERON:0000465).
Currently, in Uberon we are overriding those restrictions by injecting tigher constraints: a domain restriction to 'organism subdivision' (UBERON:0000475) and a range restriction to 'subdivision of skeleton' (UBERON:0010912).
A ticket to upstream those tighter restrictions to RO has gone nowhere in more than one year
(oborel/obo-relations#700).
This PR removes the Uberon-injected restrictions and leaves it to RO to decide whether they should adopt them or not.
Of note, the only inferred axiom that those tighter restrictions give us is this one:
So we don't lose much by removing them until they are (maybe) added back directly by RO.
Related to #2453