Replace supplies and drains relations by more specific relations #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RO now provides 'vessel supplies blood to' (RO:0020101) as a more specific variant of 'supplies' (RO:0002178). The new relation is domain-restricted to 'blood vessel' (UBERON:0001981). We use that new relation wherever 'supplies' was used to qualify a blood vessel. Likewise for 'vessel drains blood from' (RO:0020102), which is a more specific variant of 'drains' (RO:0002179). Recently introduced patterns for arteries and veins (#3288) already use the more specific relations. No longer using 'drains' and 'supplies' wherever a blood vessel is involved means that we no longer need to inject our own domain and range restrictions to those relations, so we remove those injections as well (#2453).
'supraorbital artery' (UBERON:0015160) supplies blood to the 'frontal sinus' (UBERON:0001760), but 'frontal sinus' represents an immaterial anatomical cavity, and is therefore incompatible with the range restriction of the 'vessel supplies blood to' (RO:0020101) relation. We replace the object of that relation to 'mucosa of frontal sinus' (a material anatomical entity) instead.
We redefine 'intercostal artery' (respectively 'intercostal vein') so that it is said to supply blood to (resp. drain blood from) 'intercostal muscle' rather than 'intercostal space'. 'intercostal space' is not suitable here as it is an immaterial entity, which violates the range restriction of the 'vessel supplies blood to' (resp. 'vessel drains blood from') relation.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Cancelled in favour of the original proposal in #3426. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR supersedes #3426; it is almost identical to it, except that the fix to the unsatisfiability of “intercostal vein“ and “intercostal artery” is to redefine those terms to say they drain/supply blood from/to the intercostal muscles, instead of introducing a new term like “intercostal element“.)
RO now provides 'vessel supplies blood to' (RO:0020101) as a more specific variant of 'supplies' (RO:0002178). The new relation is domain-restricted to 'blood vessel' (UBERON:0001981). In this PR, we use the new relation wherever 'supplies' was used to qualify a blood vessel.
Likewise for 'vessel drains blood from' (RO:0020102), which is a more specific variant of 'drains' (RO:0002179).
Recently introduced patterns for arteries and veins (in #3288) already use the more specific relations, so this improves Uberon’s consistency. More importantly, no longer using 'supplies' and 'drains' wherever a blood vessel is involved means that we no longer need to inject our own domain restrictions to those relations, so we can remove those injections as well (#2453).
The new relations are range-restricted in RO to (material) 'anatomical structure', which causes two side-effects:
'supraorbital artery' (UBERON:0015160) is unsatisfiable because it 'supplies blood to' the 'frontal sinus' (UBERON:0001760), which is an immaterial entity. We fix that by changing the target of the relation to 'mucosa of frontal sinus' (UBERON:0005027).
'intercostal vein' (UBERON:0012197) and 'intercostal artery' (UBERON:0005612) are unsatisfiable because they drain and supply blood from and to the 'intercostal space' (UBERON:0012198), an immaterial entity. As discussed in the Uberon call of December 16th, 2024, we fix that by redefining those terms as draining/supplying blood from/to 'intercostal muscle' instead of 'intercostal space'. This causes a slight loss of information (there are more things in the intercostal space than just the intercostal muscles) but this was deemed (by Uberon editors in the aforementioned call) to be good enough.