Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unused GO terms, one of which is obsolete in GO. #573

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove some unused GO terms, one of which is obsolete in GO. #573

wants to merge 1 commit into from

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Feb 17, 2022

Fixes #530.

I deleted 'synapse part' and its subclasses 'presynaptic membrane' and 'postsynaptic membrane'. None of them had any usages in axioms. I didn't see any automated way to regenerate the go_cc_import.owl.

@balhoff balhoff requested a review from matentzn February 17, 2022 15:50
matentzn
matentzn reviewed Feb 17, 2022
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that none of these terms are used in ro-base.owl?

@balhoff
Copy link
Member Author

balhoff commented Feb 17, 2022

I looked at usages in ro-edit.owl within Protege. Shouldn't that be a superset of ro-base?

@matentzn
Copy link
Contributor

Yes it is! Thanks.

@balhoff
Copy link
Member Author

balhoff commented Feb 17, 2022

Wait—now I do see where this is "used":

synapsed_by_via_type_III_bouton expand expression to "BFO_0000051 some (GO_0042734 that BFO_0000050 some (GO_0045202 that BFO_0000051 some (GO_0097467 that BFO_0000051 some GO_0045211 that BFO_0000050 some ?Y)))"

@balhoff balhoff marked this pull request as draft February 17, 2022 15:59
@balhoff
Copy link
Member Author

balhoff commented Feb 17, 2022

I changed to draft to look at this a little further before merging.

@balhoff balhoff mentioned this pull request Feb 17, 2022
Open
@cmungall
Copy link
Contributor

any further thoughts @balhoff ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

@anitacaron anitacaron Awaiting requested review from anitacaron anitacaron will be requested when the pull request is marked ready for review anitacaron is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@balhoff balhoff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ro.owl is using GO:synapse part (GO:0044456) which is obsolete
3 participants
@balhoff @matentzn @cmungall