Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added has completed and has not completed #577

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

shawntanzk
Copy link
Collaborator

Fixes #574

@shawntanzk shawntanzk requested a review from dosumis March 7, 2022 08:16
@shawntanzk shawntanzk self-assigned this Mar 7, 2022
@dosumis
Copy link
Contributor

dosumis commented Mar 7, 2022

CC @addiehl

@cmungall
Copy link
Contributor

cmungall commented Mar 8, 2022

you will need to resolve conflicts

commens on the relation in the ticket...

@dosumis dosumis added the discussion For discussion on RO calls or at RO meeting label Mar 8, 2022
@cmungall
Copy link
Contributor

What is the status of this - I see a lot of discussion on the issue but not clear if this is ready to be merged?

@shawntanzk shawntanzk marked this pull request as draft May 24, 2022 09:36
@shawntanzk
Copy link
Collaborator Author

What is the status of this - I see a lot of discussion on the issue but not clear if this is ready to be merged?

lol, good question. From reading I think theses are the possible solutions:

  1. has_completed -> output_of (this can be done with all the options below)
  2. make an annotation property for has_not_completed that expands to have the negative (not 100% sure how to handle this personally)
  3. use capable_of instead of has_not_completed (downside is that we have to make sure individual changes make sense, and reasoner won't work well here)

I've converted this to draft as I think we are using this more as a discussion point, happy to implement stuff once we have a clear direction (thought I guess that is the difficult part)

@ddooley ddooley mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion For discussion on RO calls or at RO meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] has_completed
3 participants