-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker for android #6
base: master
Are you sure you want to change the base?
Conversation
scripts/docker-entrypoint.sh
Outdated
set -eux | ||
|
||
# OpenJDK | ||
if ! command -v java >/dev/null 2>&1; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't install java through package manager once?
scripts/docker-entrypoint.sh
Outdated
echo "tauri-cli v2 already installed." | ||
else | ||
echo "Installing tauri-cli v2..." | ||
cargo install tauri-cli --version "^2.0.0" --locked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be a part of image
scripts/docker-entrypoint.sh
Outdated
MISSING_TARGETS=() | ||
|
||
for target in aarch64-linux-android armv7-linux-androideabi i686-linux-android x86_64-linux-android; do | ||
if ! rustup target list --installed | grep -q "^${target}\$"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add all target in image
No description provided.