feat: Add AES confmap provider #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shazlehu
requested review from
dpaasman00,
BinaryFissionGames and
a team
as code owners
shazlehu
deleted the
samhazlehurst/bpop-912-add-credential-encryption-provider-to-bp-agent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Adds the AES confmap provider for obfuscating sensitive config values.
You can test that the provider works using this PR stack and setting a key under the advanced config options. When you inspect the config on the disc, any sensitive parameters should be replaced with
${aes:<base 64 encoded, encrypted string>}Checklist