Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: github_host option defaulting to github.com #13

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Apr 9, 2024

Github Enterprise users may have an alternative URL that they connect to when cloning repos. This URL will contain the required authentication user / token.

Failures look like this when set to a bad host: https://github.com/jsirianni/bindplane-gitops-example/actions/runs/8634598214/job/23670409872

remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/jsirianni/bindplane-gitops-example.git/'

When token and github_url are unset, write back correctly fails with: https://github.com/jsirianni/bindplane-gitops-example/actions/runs/8634613162/job/23670463116

Validating options and configuring client profile.
token or github_url are required when target_branch is set.

Leaving the option unset defaults to using github_token and passes: https://github.com/jsirianni/bindplane-gitops-example/actions/runs/8634561203/job/23670291925

Screenshot from 2024-04-10 12-21-52

@jsirianni jsirianni marked this pull request as ready for review April 9, 2024 21:03
@jsirianni jsirianni requested a review from cpheps April 10, 2024 16:28
@jsirianni jsirianni merged commit c33fec8 into main Apr 10, 2024
4 checks passed
@jsirianni jsirianni deleted the feat/option/github-host branch April 10, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants