-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial Action #2
Conversation
…ecause it always matters
bindplane get configuration -o yaml --export > configuration.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the PR instructions it has plural of these file names destinations.yaml
and configurations.yaml
what do we want? It failed for me as I followed the PR instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you got it working. The path you export the initial resources too should match whatever you configure your action to point to, in your repo you have:
destination_path: destination.yaml
configuration_path: configuration.yaml
but you could have anything. My example repo has the following structure:
.
├── otel
│ ├── k8s-cluster.yaml
│ ├── k8s-gateway.yaml
│ └── k8s-node.yaml
├── README.md
└── resources
├── configurations
│ └── resource.yaml
└── destinations
└── resource.yaml
Where resources/
is the top level directory for my destinations and configurations. The output dir is otel
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a private repo here. The action ran
https://github.com/cpheps/bpop-actions/actions/runs/7640827115 but I did not see a commit. I haven't touched the repo since this ran so you can see what happened.
This should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great
* wip: auto rollout * test against this branch * add auto rollout to workflow * print config apply output * check rollout status * check for pending rollout * shellcheck: Fix loop logic * install jq * add enable_auto_rollout to readme * revert this change, use external repo for testing this pr * check for stable configs as well * remove branch from ci, we will test using an external repo * use case
Initial action has the following features
The repo contains Ci configuration for testing against a bindplane instance (local docker).
Testing
I have an example repo here, but you should try it on your own.
You can test with the following steps
BINDPLANE_REMOTE_URL
with valuehttps://<bindplane dev or stage>.com
BINDPLANE_SECRET_KEY
You should expect actions to kick off. You should also expect to see a new commit from the action containing your configurations at the directory
otel/
.If you change your configurations / destinations, you should expect them to be applied. You should also expect to see a pending rollout in the ui.
edit: We added an
enable_auto_rollout
option. If you include an additionalwith
param,enable_auto_rollout: true
, you should expect the configuration to automatically rollout.