feat: Auto rollout #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirianni
commented
Jan 24, 2024
Comment on lines
+161
to
+162
| bindplane apply "$configuration_path" > configuration.out | ||
| cat configuration.out |
There was a problem hiding this comment.
Capture the output in configuration.out to be used later. Cat it out so it is still visable in the action output.
jsirianni
commented
Jan 24, 2024
| # When auto rollout is enabled | ||
| if [ "$enable_auto_rollout" = true ]; then | ||
| echo "Auto rollout enabled." | ||
| awk '{print $2}' < configuration.out | while IFS= read -r config |
There was a problem hiding this comment.
This loops through each line in the file. The file looks like this:
Configuration k8s-cluster:1 created
Configuration k8s-gateway:1 created
Configuration k8s-node:1 created
Awk is used to grab the second column, which would be the config name with the version suffix. This allows us to do a bindplane rollout status $config for each configuration that was applied. This is better than checking all configs that might exist in bindplane, we only want to check on configs managed by the action.
jsirianni
force-pushed
the
auto-rollout
branch
from
391b55a
to
8d7a6dc
Compare
cpheps
approved these changes
Jan 29, 2024
jsirianni
added a commit
that referenced
this pull request
Jan 29, 2024
* wip * fix matrix * install cli * pull image * run bindplane in background * arg syntax * fix action name and uses field * switch to docker * cURL * put bindplane binary in path * fix args and add shellcheck to ci * remove missing function call * Add debug resource get * fix paths * remove dir support * fix resources for tests * wait for bindplane to become ready * try setting bindplane host * detect runner ip * detect internal ip * debug * use first addr * exec into container * test additional version * try write back without commit * test write back * ci * test write back * test write back * test write back * try write back * add github auth * BindPlane OP Action: Update OTEL Configs * clone repo * try again * latest * BindPlane OP Action: Update OTEL Configs * shellcheck * prevent out of order commits * BindPlane OP Action: Update OTEL Configs * shellcheck * return early if nothing to commit * fix out path * clone repo outside of orig context * BindPlane OP Action: Update OTEL Configs * BindPlane OP Action: Update OTEL Configs * comment * always run * fix workflow example * fix rm * skip apply if not on target branch * update org * rename params * fix bad rename * enable bool for write back. Move branch check outside of write back because it always matters * some cleanup * readme * badge * readme job name * grab pending version * add logging useful for debugging running action * remove unused files * use latest instead of pending * cleanup zip output * feat: Auto rollout (#4) * wip: auto rollout * test against this branch * add auto rollout to workflow * print config apply output * check rollout status * check for pending rollout * shellcheck: Fix loop logic * install jq * add enable_auto_rollout to readme * revert this change, use external repo for testing this pr * check for stable configs as well * remove branch from ci, we will test using an external repo * use case --------- Co-authored-by: bindplane-op-action <bindplane-op-action>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.