forked from open-telemetry/opentelemetry-collector-contrib
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[vcenterreceiver] Updated units on several metrics (open-telemetry#34946
) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The following change works to update several metrics units to be more inline with the semantics declared here: https://opentelemetry.io/docs/specs/semconv/general/metrics/#instrument-units Specifically it changes all the uses of `sec` to `s` and also updates the incorrect unit usage of `{MHz}` to `MHz` on a couple metrics. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> All golden package tests were updated, as well as integration tests. **Documentation:** <Describe the documentation added.> Documentation was updated with mdatagen with the use of `make generate`
- Loading branch information
1 parent
5822332
commit d25990b
Showing
8 changed files
with
161 additions
and
119 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
| component: vcenterreceiver | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Updated units on several metrics to be more in line with documented semantics. | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| issues: [34946] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | | ||
| The following are the metrics with their respective unit changes: | ||
| - vcenter.datacenter.cpu.limit ({MHz} -> MHz) | ||
| - vcenter.cluster.cpu.limit ({MHz} -> MHz) | ||
| - vcenter.cluster.cpu.effective ({MHz} -> MHz) | ||
| - vcenter.cluster.vsan.operations ({operations/sec} -> {operations/s}) | ||
| - vcenter.cluster.vsan.congestions ({congestions/sec} -> {congestions/s}) | ||
| - vcenter.host.network.packet.error.rate ({errors/sec} -> {errors/s}) | ||
| - vcenter.host.network.packet.rate ({packets/sec} -> {packets/s}) | ||
| - vcenter.host.network.packet.drop.rate ({packets/sec} -> {packets/s}) | ||
| - vcenter.host.vsan.operations ({operations/sec} -> {operations/s}) | ||
| - vcenter.host.vsan.congestions ({congestions/sec} -> {congestions/s}) | ||
| - vcenter.resource_pool.cpu.usage ({MHz} -> MHz) | ||
| - vcenter.vm.network.throughput (By/sec -> By/s) | ||
| - vcenter.vm.network.packet.rate ({packets/sec} -> {packets/s}) | ||
| - vcenter.vm.vsan.operations ({operations/sec} -> {operations/s}) | ||
| # If your change doesn't affect end users or the exported elements of any package, | ||
| # you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
| # Optional: The change log or logs in which this entry should be included. | ||
| # e.g. '[user]' or '[user, api]' | ||
| # Include 'user' if the change is relevant to end users. | ||
| # Include 'api' if there is a change to a library API. | ||
| # Default: '[user]' | ||
| change_logs: [user] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 15 additions & 15 deletions
30
receiver/vcenterreceiver/internal/metadata/generated_metrics.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.