fix(vcenter_parser): Add route for vCenter json parsing #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirianni
reviewed
Oct 5, 2023
There was a problem hiding this comment.
Looks good. Unless you have already, we should test the following cases:
- Our vcenter server still works with RFC5424
- Example GCVE json logs work without error.
Generally I will do something like this to test TCP based logs (assuming port 5142):
echo '{"timestamp": "2023-07-14T11:26:45.477", "severity": "info", "message' | nc localhost 5142
You can replace the json log I am using with one of the example GCVE logs that we have.
jsirianni
reviewed
Oct 9, 2023
jsirianni
reviewed
Oct 9, 2023
jsirianni
approved these changes
Oct 9, 2023
schmikei
reviewed
Oct 10, 2023
schmikei
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds a route to parse json coming from vCenter, based off #243
Please check that the PR fulfills these requirements