-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rm context command #30
Add rm context command #30
Conversation
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This behavior makes sense to me! 🙂
Adding test + docs would be cool!
I think there has to be some extra care when writing documentation and talking about this. With this sentence, some may understand that there is an API in Observatorium to manage tenants and that |
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
@saswatamcode @douglascamata thanks for the review! I've added test + modified the docs. I think we can improve docs in another pr (related issue: #28) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👓
Co-authored-by: Matej Gera <[email protected]>
I thought would be nice to have a command that removes the context, without the need to individually remove tenant and/or api.
This PR adds the following behavior:
obsctl context rm <api>/<tenant>
is the commandrm
command cannot be used. The commandobsctl context api rm <api>
can be used though.If we agree on this behavior, I'd then add tests + update docs :)
It partially implements #23
Signed-off-by: Jéssica Lins [email protected]