add imagepullpolicy support.

[morvencao]

ref: observatorium/operator#76
Signed-off-by: morvencao [email protected]

[saswatamcode]

Thanks for this! Can you run make generate once so that the jsonnet changes are reflected in configuration/? Build fails due to this. 🙂

[morvencao]

thanks @saswatamcode Done.

[squat]

The e2e tests are failing because it seems that kube-prometheus renamed a file in main. We should pin the version of the file we are downloading so that we are not so fragile.

Thanks for using kind! 😊
error: unable to read URL "https://raw.githubusercontent.com/coreos/kube-prometheus/master/manifests/setup/prometheus-operator-0servicemonitorCustomResourceDefinition.yaml", server reported 404 Not Found, status code=404

The new file is located at: https://raw.githubusercontent.com/prometheus-operator/kube-prometheus/main/manifests/setup/0servicemonitorCustomResourceDefinition.yaml

[morvencao]

I found @saswatamcode raised another PR to fix the failing e2e tests, see: #447

[saswatamcode]

Have closed #447 in favor of #448. 🙂

[morvencao]

Rebased the code changes to pass the e2e tests.

[morvencao]

@saswatamcode @squat PTAL

[saswatamcode]

Thanks! LGTM

[squat]

@morvencao this PR seems to only add the field for a small subset of all of the components. Are these the only ones you are interested in? Or perhaps the only ones that don't expose this option?

[morvencao]

thanks @squat
Just updated minio for the imagepullpolicy, for thanos resources, they don't have exposed this option yet.

[morvencao]

@squat ^^

[bwplotka]

Thanks!