feat: OB-36691 add lambda and s3 bucket to record push metrics config #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-virjramakrishnan
force-pushed
the
viraj/metrics-lambda
branch
7 times, most recently
from
8665852 to
7bb217f
Compare
obs-gh-virjramakrishnan
changed the title
obs-gh-virjramakrishnan
force-pushed
the
viraj/metrics-lambda
branch
from
7bb217f to
38490ce
Compare
obs-gh-virjramakrishnan
force-pushed
the
viraj/metrics-lambda
branch
3 times, most recently
from
4d1837a to
bc72120
Compare
obs-gh-virjramakrishnan
force-pushed
the
viraj/metrics-lambda
branch
2 times, most recently
from
c2407a5 to
31e420c
Compare
obs-gh-virjramakrishnan
force-pushed
the
viraj/metrics-lambda
branch
5 times, most recently
from
ed39eec to
406b3e2
Compare
| FilterUri: !Ref MetricStreamFilterUri | ||
| FilterUri: !If | ||
| - DeployLambda | ||
| - 's3://observeinc/cloudwatchmetrics/filters/default.yaml' |
There was a problem hiding this comment.
does the lambda ever use this file? if not does this even need to be a real s3 file?
There was a problem hiding this comment.
also we should write some comment here to explain why this is necessary
|
any unit tests around lambda vs. path in the actual app parameters and how that ends up affecting the result? |
obs-gh-virjramakrishnan
force-pushed
the
viraj/metrics-lambda
branch
3 times, most recently
from
db1970b to
84505ad
Compare
apps/metricstream/template.yaml
Outdated
| # will be replaced with the contents of the file | ||
| # specified by the FilterUri parameter. | ||
| # The filterURI parameter is a decided in the | ||
| # parent stack, where, depending on whether we are |
There was a problem hiding this comment.
can you install this AWS Sam app separately without installing the whole stack? you should be able to
obs-gh-virjramakrishnan
force-pushed
the
viraj/metrics-lambda
branch
from
84505ad to
2fc414d
Compare
apps/stack/template.yaml
Outdated
| - DeployLambda | ||
| - 's3://observeinc/cloudwatchmetrics/filters/default.yaml' | ||
| - !Ref MetricStreamFilterUri | ||
| # default.yaml must exist. When using a lambda for config we use |
There was a problem hiding this comment.
# We provide a yaml file URI here where the contents are a sentinel value that the user would never enter.
# Then the lambda modifies the metricstream to reflect the actual config provided.
# We need this sentinel value here initially so that if we switch back to the yaml based approach,
# the cloudformation stack will recognize that the value from the yaml file has changed and will update.
obs-gh-alexlew
approved these changes
Oct 17, 2024
obs-gh-virjramakrishnan
force-pushed
the
viraj/metrics-lambda
branch
from
2fc414d to
dcd9433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.