Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(traces): use v2 otel endpoint for tracing #85

Closed
wants to merge 1 commit into from

Conversation

yasar-observe
Copy link
Contributor

@yasar-observe yasar-observe commented Dec 13, 2023

DO NOT MERGE UNTIL ALL CUSTOMERS HAVE MIGRATED TO LATEST OTEL APP!!
Our otel endpoint is being updated to flatten attributes. We need to update the charts to use the new endpoint when it hits production. This updates the charts to accommodate.

Copy link
Contributor

github-actions bot commented Dec 13, 2023

The following chart updates are necessary:

diff --git a/charts/stack/Chart.lock b/charts/stack/Chart.lock
index 1e1ba43..6ce7ad1 100644
--- a/charts/stack/Chart.lock
+++ b/charts/stack/Chart.lock
@@ -13,6 +13,6 @@ dependencies:
   version: 0.1.3
 - name: traces
   repository: file://../traces
-  version: 0.2.7
-digest: sha256:2f3edd9700b20aae7eb9adb67d38df20602377b22a8e0b9a9236af4362457823
-generated: "2023-11-29T12:42:11.5012943-05:00"
+  version: 0.2.8
+digest: sha256:d86f4f6ae8cdf6db3b494920b07885b1a11b7ff4523e825523717586db533873
+generated: "2023-12-13T19:03:08.61492923Z"
diff --git a/charts/stack/Chart.yaml b/charts/stack/Chart.yaml
index 6bd8ec4..beb52bf 100644
--- a/charts/stack/Chart.yaml
+++ b/charts/stack/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: stack
 description: Observe Kubernetes agent stack
 type: application
-version: 0.4.12
+version: 0.4.13
 dependencies:
   - name: logs
     version: 0.1.13
@@ -21,7 +21,7 @@ dependencies:
     repository: file://../proxy
     condition: proxy.enabled
   - name: traces
-    version: 0.2.7
+    version: 0.2.8
     repository: file://../traces
     condition: traces.enabled
 maintainers:
diff --git a/charts/traces/Chart.yaml b/charts/traces/Chart.yaml
index 30e3e22..b84a046 100644
--- a/charts/traces/Chart.yaml
+++ b/charts/traces/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: traces
 description: Observe OpenTelemetry trace collection
 type: application
-version: 0.2.7
+version: 0.2.8
 dependencies:
   - name: opentelemetry-collector
     version: 0.74.1

@yasar-observe yasar-observe force-pushed the yasar/trace-v2 branch 5 times, most recently from c8f0adf to fc26ad0 Compare December 13, 2023 21:02
@yasar-observe yasar-observe changed the title fix: use v2 otel endpoint for tracing fix(traces): use v2 otel endpoint for tracing Dec 13, 2023
@yasar-observe yasar-observe marked this pull request as ready for review December 13, 2023 21:23
Copy link
Contributor

@obs-gh-colinhutchinson obs-gh-colinhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right

helm template --namespace=observe \
    observe-traces observe/traces \
    --set global.observe.collectionEndpoint="${OBSERVE_ENDPOINT}" \
    --set observe.token.value="${OBSERVE_OTEL_TOKEN}" > traces-old.yaml

helm template --namespace=observe \
    observe-traces ~/github.com/observeinc/helm-charts/charts/traces \
    --set global.observe.collectionEndpoint="${OBSERVE_ENDPOINT}" \
    --set observe.token.value="${OBSERVE_OTEL_TOKEN}" > traces-new.yaml

diff traces-old.yaml traces-new.yaml
43c43
<         endpoint: 'https://130348791288.collect.observe-eng.com/v1/otel'
---
>         endpoint: 'https://130348791288.collect.observe-eng.com/v2/otel'
254c254
<         checksum/config: 5ee039f0c2b8f2e86536ac1a46605ff4542cef2af5193585dab583268786d781
---
>         checksum/config: ca22e3ee2ec6018a2aa3c235ded89f627fb1e3be1d810774f6cc38b00818eaa4
362c362
<       - -q="Path -> ^/v1/otel/v1/traces$"
---
>       - -q="Path -> ^/v2/otel/v1/traces$"

@obs-gh-kaisu
Copy link

make the v1 vs v2 endpoint configurable

@obs-gh-konstantintikhonov
Copy link
Contributor

Closing this because #115 makes the otel endpoint version configurable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants