-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(traces): use v2 otel endpoint for tracing #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following chart updates are necessary:
|
c8f0adf
to
fc26ad0
Compare
fc26ad0
to
6df1454
Compare
obs-gh-colinhutchinson
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks right
helm template --namespace=observe \
observe-traces observe/traces \
--set global.observe.collectionEndpoint="${OBSERVE_ENDPOINT}" \
--set observe.token.value="${OBSERVE_OTEL_TOKEN}" > traces-old.yaml
helm template --namespace=observe \
observe-traces ~/github.com/observeinc/helm-charts/charts/traces \
--set global.observe.collectionEndpoint="${OBSERVE_ENDPOINT}" \
--set observe.token.value="${OBSERVE_OTEL_TOKEN}" > traces-new.yaml
diff traces-old.yaml traces-new.yaml
43c43
< endpoint: 'https://130348791288.collect.observe-eng.com/v1/otel'
---
> endpoint: 'https://130348791288.collect.observe-eng.com/v2/otel'
254c254
< checksum/config: 5ee039f0c2b8f2e86536ac1a46605ff4542cef2af5193585dab583268786d781
---
> checksum/config: ca22e3ee2ec6018a2aa3c235ded89f627fb1e3be1d810774f6cc38b00818eaa4
362c362
< - -q="Path -> ^/v1/otel/v1/traces$"
---
> - -q="Path -> ^/v2/otel/v1/traces$"
make the v1 vs v2 endpoint configurable |
Closing this because #115 makes the otel endpoint version configurable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL ALL CUSTOMERS HAVE MIGRATED TO LATEST OTEL APP!!
Our otel endpoint is being updated to flatten attributes. We need to update the charts to use the new endpoint when it hits production. This updates the charts to accommodate.