Skip to content

Commit

Permalink
fix(traces): remove superfluous prefixing (#86)
Browse files Browse the repository at this point in the history
When we introduced a new shim base (deployment, daemonset), we did not
prefix them accordingly. #84 reintroduced the observe- prefix for the
resulting controllers, but inadvertently double-prefixed all resources
coming in from base/.

This PR fixes things by removing prefixing from base/kustomization.yaml.
You can't build a usable traces stack without one of daemonset or
deployment, so gate things on either of those layers.
  • Loading branch information
jta authored Nov 14, 2022
1 parent e517434 commit 073ab25
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions bases/traces/base/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
---
namePrefix: observe-

resources:
- clusterrole.yaml
- clusterrolebinding.yaml
Expand Down

0 comments on commit 073ab25

Please sign in to comment.