feat: add mac support #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-mattcotter
force-pushed
the
OB-32891-mac-os-support
branch
from
48c0e72 to
97d84dc
Compare
|
|
||
| service_name="com.observeinc.agent" | ||
| observeagent_install_dir="/usr/local/observe-agent" | ||
| # TODO download the file instead of using the local built zip |
There was a problem hiding this comment.
I would like to leave this as a follow up since the release process change is included in this PR.
| @@ -0,0 +1,12 @@ | |||
| receivers: | |||
| filestats/agent: | |||
| include: '/etc/observe-agent/otel-collector.yaml' | |||
There was a problem hiding this comment.
this path would be /usr/local/observe-agent right?
| @@ -0,0 +1,18 @@ | |||
| receivers: | |||
| filelog/host_monitoring: | |||
| include: [/var/log/**/*.log, /var/log/syslog] | |||
There was a problem hiding this comment.
does syslog exist on macs? or is it something else?
There was a problem hiding this comment.
Good point; it's /var/log/system.log. That's covered by the glob, so I just removed syslog.
| receivers: | ||
| filelog/agent-config: # TODO: Add observe-agent.yaml once we can obfuscate sensitive config fields | ||
| include: [/etc/observe-agent/otel-collector.yaml] | ||
| start_at: beginning |
There was a problem hiding this comment.
same is this filepath correct?
There was a problem hiding this comment.
Correct to both, it's /usr/local/observe-agent/config/otel-collector.yaml. Updated in both places, thanks!
obs-gh-mattcotter
force-pushed
the
OB-32891-mac-os-support
branch
from
8bebfa9 to
6e9cd58
Compare
obs-gh-alexlew
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OB-32891 add Mac support
This creates a script to install the observe agent and register it as a launch daemon on Mac OS. Useful resource: https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPSystemStartup/Chapters/CreatingLaunchdJobs.html
Local testing:
Checklist