Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add and update examples #51

Merged
merged 5 commits into from
Oct 24, 2024
Merged

chore: add and update examples #51

merged 5 commits into from
Oct 24, 2024

Conversation

obs-gh-nikhildua
Copy link
Contributor

@obs-gh-nikhildua obs-gh-nikhildua commented Oct 24, 2024 •
edited
Loading

What does this PR do?

  • Updates service_account creation
  • Adds API Enablement modules

Motivation

  • We had a few customers wanting automation for the tedious process of service account/apis that is highly error prone when done manually
  • This allows doing so via terraform

Testing

Tested in new project test-svc-account-automation for following:

  • Enabled APIs via api_module
  • Created SVC Acount via service_account module
  • Create Observe Collection via project module
  • Used output to ensure data is flowing into Observe properly

@obs-gh-nikhildua obs-gh-nikhildua changed the title Nikhil/update examples chore: add and update examples Oct 24, 2024
@obs-gh-nikhildua obs-gh-nikhildua marked this pull request as ready for review October 24, 2024 20:04
@obs-gh-nikhildua obs-gh-nikhildua requested a review from a team as a code owner October 24, 2024 20:04
@obs-gh-nikhildua obs-gh-nikhildua merged commit 6c97b37 into main Oct 24, 2024
3 checks passed
@obs-gh-nikhildua obs-gh-nikhildua deleted the nikhil/update-examples branch October 24, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthur-observe arthur-observe arthur-observe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obs-gh-nikhildua @arthur-observe