feat: support targeting Everyone group before RBAC v2 is turned on (#172

)

client/meta/rbac_group.go

@@ -2,7 +2,7 @@ package meta
 
 import (
 	"context"
-	"fmt"
+	"github.com/vektah/gqlparser/v2/gqlerror"
 
 	oid "github.com/observeinc/terraform-provider-observe/client/oid"
 )
@@ -55,7 +55,14 @@ func (client *Client) LookupRbacGroup(ctx context.Context, name string) (*RbacGr
 		}
 	}
 	if out == nil {
-		return nil, fmt.Errorf("rbacgroup not found")
+		return nil, gqlerror.List{
+			&gqlerror.Error{
+				Message: "rbacgroup not found",
+				Extensions: map[string]interface{}{
+					"code": ErrNotFound,
+				},
+			},
+		}
 	}
 	return out, nil
 }

observe/data_source_rbac_group.go

@@ -2,6 +2,7 @@ package observe
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -65,6 +66,18 @@ func dataSourceRbacGroupRead(ctx context.Context, data *schema.ResourceData, met
 		r, err = client.LookupRbacGroup(ctx, name)
 	}
 
+	// The Everyone group only exists if RBAC v2 is turned on for the customer.
+	// However, we want to support creating RBAC v2 statements before it's turned on,
+	// so we return the special Everyone group id 1 if name is "Everyone" and there
+	// is no existing v1 group called "Everyone".
+	if err != nil && gql.HasErrorCode(err, gql.ErrNotFound) && name == "Everyone" {
+		r = &gql.RbacGroup{
+			Id:   fmt.Sprintf("o::%s:rbacgroup:%d", client.CustomerID, 1),
+			Name: "Everyone",
+		}
+		err = nil
+	}
+
 	if err != nil {
 		diags = diag.FromErr(err)
 		return