Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support rbac v2 statements #157

Closed
wants to merge 2 commits into from
Closed

feat: support rbac v2 statements #157

wants to merge 2 commits into from

Conversation

obs-gh-abhinavpappu
Copy link
Collaborator

  • add version field
  • update validation to account for new v2 statement expectations
  • add acceptance tests

@obs-gh-abhinavpappu
feat: support rbac v2 statements
1cff30b 
- added version field
- updated validation to account for new v2 statement expectations
@vikramraman
Copy link
Contributor

The acceptance tests are failing on invalid rbac statements

@obs-gh-abhinavpappu
Copy link
Collaborator Author

yeah i know what the issue is, the validation changes i made caused v1 statements specifying only an object type to be invalid due to the ExactlyOneOf, i'm thinking i'll just remove the ExactlyOneOf

@obs-gh-abhinavpappu
Copy link
Collaborator Author

replaced by #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramraman vikramraman Awaiting requested review from vikramraman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obs-gh-abhinavpappu @vikramraman