-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: update monitorv2 to allow inline actions #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but overall looks good!
// TODO: remove this. we are only doing this for shared actions | ||
"inline": { // Boolean | ||
Type: schema.TypeBool, | ||
Optional: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove? along with corresponding code in newMonitorV2ActionInput
We moved the internal API to support one-shot create/update call SaveMonitorV2WithActions. This migrates the existing monitorv2 resource to use that function, which also allows for specifying shared actions (current feature support) and now also inline actions. We require that shared actions be separately managed resources and set using action id (again, current feautre support). Action ID is now optional, and instead a full action definition can be given inline which we translate to an Inline:true (private action).
220a5aa
to
5374ea6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
We moved the internal API to support one-shot create/update call SaveMonitorV2WithActions. This migrates the existing monitorv2 resource to use that function, which also allows for specifying shared actions (current feature support) and now also inline actions. We require that shared actions be separately managed resources and set using action id (again, current feautre support). Action ID is now optional, and instead a full action definition can be given inline which we translate to an Inline:true (private action).