fix: remove omitempty directive from MonitorV2ActionInput.inline to prevent nondeterministic generation #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revent nondeterministic generation The MonitorV2ActionInput type is used by multiple mutations, only one of which includes the genqlient directive to include `omitempty` in the generated Go type. This results in the generated type sometimes including omitempty and sometimes not, depending on the order in which the GraphQL files are processed.
obs-gh-maxhahn
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MonitorV2ActionInput type is used by multiple mutations, only one of which includes the genqlient directive to include
omitemptyin the generated Go type. This results in the generated type sometimes including omitempty and sometimes not, depending on the order in which the GraphQL files are processed.