feat: Add conditions to monv2 action rules #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-abhinavpappu
approved these changes
Dec 10, 2024
| @@ -306,6 +306,33 @@ func monitorV2FlattenWebhookHeader(gqlHeader gql.MonitorV2WebhookHeader) interfa | |||
| return header | |||
| } | |||
|
|
|||
| func newMonitorV2ComparisonExpressionInput(path string, data *schema.ResourceData) (input *gql.MonitorV2ComparisonExpressionInput, diags diag.Diagnostics) { | |||
There was a problem hiding this comment.
nit: this probably belongs in resource_monitor_v2.go
| @@ -302,6 +315,8 @@ func TestAccObserveMonitorV2MultipleActionsEmailViaOneShot(t *testing.T) { | |||
| resource.TestCheckResourceAttr("observe_monitor_v2.first", "actions.0.action.0.type", "email"), | |||
| resource.TestCheckResourceAttr("observe_monitor_v2.first", "actions.0.send_reminders_interval", "10m0s"), | |||
| resource.TestCheckResourceAttr("observe_monitor_v2.first", "actions.1.send_reminders_interval", "20m0s"), | |||
| resource.TestCheckResourceAttr("observe_monitor_v2.first", "actions.1.conditions.0.compare_terms.0.comparison.0.compare_fn", "equal"), | |||
| resource.TestCheckResourceAttr("observe_monitor_v2.first", "actions.1.conditions.0.compare_terms.0.column.0.column_path.0.name", "description"), | |||
| ), | |||
There was a problem hiding this comment.
would be good to check the value_string as well
observe/resource_monitor_v2.go
Outdated
| // not support it, so we don't here either. | ||
| "compare_terms": { // [MonitorV2ComparisonTerm!] | ||
| Type: schema.TypeList, | ||
| Optional: true, |
There was a problem hiding this comment.
oh wait this should probably be required with minitems 1
There was a problem hiding this comment.
oh, good point. until i add support for sub-expressions, it is a minitems=1 instead of a exactlyoneof kind of thing, huh?
There was a problem hiding this comment.
oh i see, yeah can change it to exactlyoneof once sub-expressions are implemented
obs-gh-catherman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.