feat: add schema support for reference tables #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikramraman
reviewed
Feb 11, 2025
| func referenceTableToResourceData(d *rest.ReferenceTable, data *schema.ResourceData) (diags diag.Diagnostics) { | ||
| if err := data.Set("oid", d.Oid().String()); err != nil { | ||
| func newReferenceTableSchemaConfig(data *schema.ResourceData) (input []rest.ReferenceTableSchemaInput, diags diag.Diagnostics) { | ||
| // We're using GetRawConfig() here instead of Get() or GetOk() because we only want to include |
There was a problem hiding this comment.
I wonder if we could leverage PlanModifiers instead: https://developer.hashicorp.com/terraform/plugin/framework/resources/plan-modification#attribute-plan-modification
This would be configured on the schema definition for the field, and allows us to modify the plan as relevant.
There was a problem hiding this comment.
Looks like PlanModifiers are only supported for the Framework and not the SDK. But yes, it does give us what we need to implement this behavior (and in fact from what I can tell based on the docs, I think this behavior is default in the Framework)
vikramraman
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to use
data.GetRawConfig()to work around a terraform limitation, see comment for details.