New resource: dataset_outbound_share
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I11d87cebd4d568944fb5419e556bd96b74b36cce
|
Tests are failing on a server side issue that results in the status waiter timing out. Ready for review though because the tests should pass once the server is fixed. |
bendrucker
force-pushed
the
add-dataset-outbound-share
branch
from
abbd966 to
23ac5df
Compare
vikramraman
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
observe_dataset_outbound_sharewhich associates a dataset with an outbound share, with a user defined schema/view and freshness. Thesnowflake_share_outboundresource manages the Snowflake share itself.Currently, this is failing on a timeout because the status remains pending for 2m. I'm amending that to 5m but there's a good chance there's a permanent issue here. I'll have to look into server logs to see what's going wrong under the hood.