Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unexpected
go.sum
diffs by vendoringgenqlient
's top level package, which provides its CLI. Previously, only the underlying Go package (github.com/Khan/genqlient/graphql
) was actuallyimport
-ed in a Go file, so the CLI-providing package didn't get considered forgo.sum
. By including-mod=mod
, we had explicitly directed Go to not try to load this package from thevendor/
dir (which would fail) and instead use the normal implicit module downloading. When this happened, Go would record downloaded dependencies ingo.sum
.In dependency update PRs like #70, this caused unexpected diffs: