Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: upgrade to 1.20 #79

Merged
merged 1 commit into from
Nov 30, 2023
Merged

go: upgrade to 1.20 #79

merged 1 commit into from
Nov 30, 2023

Conversation

bendrucker
Copy link
Contributor

Upgrades from Go 1.18 to 1.20. Workflows use go.mod to decide which version to build on:

terraform-provider-observe/.github/workflows/test.yml

Lines 22 to 24 in 8f041b6

- uses: actions/setup-go@v4
with:
go-version-file: go.mod

Dependencies will start requiring this if they make use of new functionality, such as in #77 where a new provider SDK version is using errors.Join.

@bendrucker bendrucker enabled auto-merge (squash) November 30, 2023 19:50
obs-gh-konstantintikhonov
obs-gh-konstantintikhonov approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@obs-gh-konstantintikhonov obs-gh-konstantintikhonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bendrucker bendrucker merged commit ffb3713 into master Nov 30, 2023
5 checks passed
@bendrucker bendrucker deleted the go-1.20 branch November 30, 2023 20:18
@bendrucker bendrucker mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obs-gh-konstantintikhonov obs-gh-konstantintikhonov obs-gh-konstantintikhonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bendrucker @obs-gh-konstantintikhonov