feat: update all gql schemas and fix typings issues #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-alexlew
commented
Jan 17, 2024
| @@ -61,8 +61,10 @@ func (client *Client) ListDatasets(ctx context.Context) (ds []*Dataset, err erro | |||
| return nil, err | |||
| } | |||
| result := make([]*Dataset, 0) | |||
| for _, d := range resp.Datasets { | |||
There was a problem hiding this comment.
change for typings change from array of pointers to array of structs
jta
reviewed
Jan 17, 2024
observe/resource_monitor.go
Outdated
| for _, stage := range monitor.Query.Stages { | ||
| stages = append(stages, &stage) | ||
| } | ||
| stageIds, err := flattenAndSetQuery(data, stages, monitor.Query.OutputStage) |
There was a problem hiding this comment.
Feels like you could adjust flattenAndSetQuery to accept []Stage here? That would save you having to dupe the logic at the only two caller sites.
jta
reviewed
Jan 17, 2024
observe/resource_dataset.go
Outdated
| if len(gqlstages) == 0 { | ||
| return make([]string, 0), nil | ||
| } | ||
|
|
||
| queryData, err := flattenQuery(gqlstages, outputStage) | ||
| inputstages := make([]*gql.StageQuery, 0) |
There was a problem hiding this comment.
You know the length here is going to be len(gqlstages)
jta
reviewed
Jan 17, 2024
observe/resource_dataset.go
Outdated
| for _, stage := range gqlstages { | ||
| inputstages = append(inputstages, &stage) | ||
| } | ||
| queryData, err := flattenQuery(inputstages, outputStage) |
There was a problem hiding this comment.
Keep changing the signatures. This is the only caller for flattenQuery, so you should just pass gqlstages as is.
jta
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.