Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add files cache to scraper call, fix regex, add dl_all flag #15

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Add files cache to scraper call, fix regex, add dl_all flag #15

wants to merge 3 commits into from

Conversation

sourdusk
Copy link

  • Fixes an issue introduced in d1885e2 that causes program to fail due to improper implementation of FilesCache
  • Fixes an issue where a regular expression is expecting a trailing slash, causing regex to fail.
  • Adds a flag to download everything, as the default seems to imply that everything is downloaded when it is not. The creators assignment if there is no argument for creators assigns an empty set. Given that scrape_library checks to see if the creator is in this set, this causes no creators to be downloaded by default.

@obsessedcake
Copy link
Owner

Thank you for your PR! Could you please rebase on new changes? I will merge ASAP :)

@BenjiThatFoxGuy BenjiThatFoxGuy mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sourdusk @obsessedcake