Non Breaking Change Solution

obsidian-community · May 24, 2023 · ecf0669 · ecf0669
1 parent 918e058
commit ecf0669
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/docs/advanced/dataview.md b/docs/advanced/dataview.md
@@ -6,8 +6,8 @@ Create calendars inline with your notes from [dataviewjs](https://blacksmithgu.g
 ```dataviewjs
 this.container.style.minHeight = "500px";
 const { renderCalendar } = app.plugins.plugins["obsidian-full-calendar"];
-renderCalendar(this.container, [[{start: new Date(), id: "id", title: "Now and for an hour"}]])
-  .then(calendar => calendar.render());
+let calendar = renderCalendar(this.container, [[{start: new Date(), id: "id", title: "Now and for an hour"}]]);
+calendar.render()
 ```
 ````
 
@@ -16,8 +16,10 @@ renderCalendar(this.container, [[{start: new Date(), id: "id", title: "Now and f
 ````
 ```dataviewjs
 this.container.style.minHeight = "500px";
-const { renderCalendar } = app.plugins.plugins["obsidian-full-calendar"];
-renderCalendar(this.container).then(calendar => calendar.render());
+const { renderCalendar, initializeSettings } = app.plugins.plugins["obsidian-full-calendar"];
+await initializeSettings();
+let calendar = renderCalendar(this.container);
+calendar.render();
 ```
 ````
 

diff --git a/src/main.ts b/src/main.ts
@@ -64,15 +64,12 @@ export default class FullCalendarPlugin extends Plugin {
     });
 
     translateSources = translateSources;
-    renderCalendar = async (
+    renderCalendar = (
         containerEl: HTMLElement,
         eventSources: EventSourceInput[],
         settings?: ExtraRenderProps
     ) => {
         if (!eventSources) {
-            if (!this.cache.initialized) {
-                await this.saveSettings();
-            }
             eventSources = translateSources(this);
         }
         return calendarRender(containerEl, eventSources, settings);
@@ -221,11 +218,17 @@ export default class FullCalendarPlugin extends Plugin {
         );
     }
 
-    async saveSettings() {
+    initializeSettings = async () => {
+        if (!this.cache.initialized) {
+            await this.saveSettings();
+        }
+    };
+
+    saveSettings = async () => {
         new Notice("Resetting the event cache with new settings...");
         await this.saveData(this.settings);
         this.cache.reset(this.settings.calendarSources);
         await this.cache.populate();
         this.cache.resync();
-    }
+    };
 }