Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve event edit modal and fix bugs #113

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

0-ft
Copy link

@0-ft 0-ft commented May 18, 2022

This PR makes some UI changes to the event editing modal to make it cleaner and easier to understand:

Old:

image

New:

image

  • Inputs are styled to be more in-line with obsidian (with the exception of the checkbox which ideally would be made into a ToggleComponent).
  • The recurring event checkbox is removed and whether the event recurs is determined by whether any repeating days are selected
  • Buttons are moved
  • Modal title added

It also fixes two bugs:

  • the modal does not show the end date for a multi-day event when opened
  • created filenames for recurring events have an extra ) appended

@0-ft 0-ft force-pushed the main branch 2 times, most recently from c4df9db to 5459201 Compare May 18, 2022 16:21
@0-ft 0-ft changed the title Improve event edit modal and fix bug Improve event edit modal and fix bugs May 18, 2022
Copy link
Collaborator

@davish davish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for submitting this PR! I really appreciate it. I had some smaller questions, but one big thing is that I think the "recurring event" toggle is important.

Most events are one-off events, and even users who have many recurring events will not be dealing with them very frequently in the modal because once they are set you don't have to make more of them, by definition. It doesn't make sense for the repeating event radios to be visible. In fact, it might end up causing a decent amount of accidental events if users interact with the repeating event radios instead of the datepicker, assuming that clicking Monday will make an event occur on "this monday".

Hope that makes sense! Thanks again, and let me know if you have any questions.

src/overrides.css Outdated Show resolved Hide resolved
src/components/EditEvent.tsx Outdated Show resolved Hide resolved
@0-ft
Copy link
Author

0-ft commented May 19, 2022

one big thing is that I think the "recurring event" toggle is important.

I agree with what you said - I looked at a couple of different event modals from different apps and they vary in their approach, but happy to go with the one you suggest. I've changed this back to include the toggle, and have the week day selector appear only when it's checked (as before).

Other comments also implemented.

Copy link
Collaborator

@davish davish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One comment about making the safe button more prominent that could be good to do before merging. Im staying afk from my laptop for the weekend, but will try this out locally when I can and merge if it looks good.

flex-direction: column;
}

.ofc-edit-modal-event-save-button {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the save button could be a primary interactive button here, to make it stand out from the delete button and the open note button?

@davish davish added the ui Related to UI/UX rather than underlying functionality label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Related to UI/UX rather than underlying functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants