Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezones in ICS calendars #540

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ArenSH
Copy link

@ArenSH ArenSH commented Jan 30, 2024

Overview

This PR fixes issue with incorrect time for ICS events:

  • Fix timezones for ICS events
  • Fix issue with outlook timezone aliases
  • Add unit-tests for timezones and adjust existing

Related Issues

Related PRs

@Kartbllansh
Copy link

How can this PR be utilized?

@ArenSH
Copy link
Author

ArenSH commented Feb 13, 2024

@Kartbllansh I'm not sure what you mean :). When the request is merged and a new version of the plugin is published - you'll have proper timezones in your ICS events.

Alternatively, you can clone the branch with the fix, build the plugin and replace <obsidian plugins>/obsidian-full-calendar/main.js file.

@Kartbllansh
Copy link

@Kartbllansh I'm not sure what you mean :). When the request is merged and a new version of the plugin is published - you'll have proper timezones in your ICS events.

Alternatively, you can clone the branch with the fix, build the plugin and replace <obsidian plugins>/obsidian-full-calendar/main.js file.

Thanks for the reply! I just cloned the branch, but I can't figure out how to build the plugin? Can you give me a hint on how it can be done?

@ArenSH
Copy link
Author

ArenSH commented Feb 13, 2024

@Kartbllansh Sure,

  • open terminal/console in the cloned directory.
  • run npm install. (If you get "dependency conflict error" - fix zod-fast-check version to ^0.9.1 in package.json file and try again)
  • run npm run build

It will generate main.js and main.css files in the project's root. Replace <obsidian plugins>/obsidian-full-calendar/main.js file with the generated one - thats it.

@ArenSH
Copy link
Author

ArenSH commented Feb 21, 2024

Hi @davish

Can you please take a look at this request? Please let me know if anything needs to be adjusted.

@Kartbllansh
Copy link

Hi @davish

Can you please take a look at this request? Please let me know if anything needs to be adjusted.

I've been off the grid for the last few days. Yesterday I tried to do everything according to your instructions and I failed.

  1. I may have made a mistake somewhere during compilation, because it didn't work at all the first time.
  2. If you consider that everything is correct, then main.css breaks the display in the form of a table at all. If you change only js and manifest, the problem with time display remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants