Add support for loading kafka properties from classpath #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinkwekel
force-pushed
the
classpath-property-file-support
branch
from
a55e370
to
1b38827
Compare
|
Closing and reopening to retrigger the checks |
Bert-R
requested changes
Jun 8, 2024
There was a problem hiding this comment.
@alvinkwekel Thanks for this enhancement!
Code looks good, except for the name of the variable holding the properties resource. If you rename that, we can merge this PR.
| final var propertiesFile = new File(this.propertiesFile); | ||
| if (propertiesFile.isFile()) { | ||
| LOG.info("Loading properties from {}", this.propertiesFile); | ||
| Optional<AbstractResource> readablePropertyFile = StringUtils.isBlank(propertiesFile) ? Optional.empty() : |
There was a problem hiding this comment.
Suggested change
| Optional<AbstractResource> readablePropertyFile = StringUtils.isBlank(propertiesFile) ? Optional.empty() : | |
| Optional<AbstractResource> propertiesResource = StringUtils.isBlank(propertiesFile) ? Optional.empty() : |
There was a problem hiding this comment.
@Bert-R Thanks for the feedback. I've changed the variable name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the requirement to include the kafka properties from the classpath