Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link heading range #1281

Closed
wants to merge 4 commits into from
Closed

Conversation

Limezy
Copy link

@Limezy Limezy commented Nov 1, 2022

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/AnthropologieBiblique/link-heading-range

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Hello Limezy!

I found the following errors in your plugin, Link Heading Range:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. Last plugin in the list is: AnthropologieBiblique/link-heading-range


This check was done automatically.

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Hello Limezy!

I found the following errors in your plugin, Link Heading Range:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. Last plugin in the list is: AnthropologieBiblique/link-heading-range


This check was done automatically.

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Hello Limezy!

I found the following errors in your plugin, Link Heading Range:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. Last plugin in the list is: AnthropologieBiblique/link-heading-range


This check was done automatically.

@liamcain
Copy link
Collaborator

Hi @Limezy, this is a cool plugin. One thing you might want to consider though: [[page#heading1#heading2]] already has a meaning in Obsidian. It creates a nested link. It allows for linking in a document that looks like this:

# Page 1
## Summary

lorem ipsum

# Page 2
## Summary

lorem ipsum

In this document, you can link to [[#Page 1#Summary]] or [[#Page2#Summary]].

For this reason, I wonder if it makes sense to change the syntax to something else.

If you're okay with overriding the default Obsidian behavior, you might want to make a note somewhere in the README about this tradeoff.

@Limezy
Copy link
Author

Limezy commented Nov 29, 2022

Hi @liamcain, many thanks for your review and sorry for my late reply - lots of things going on at work at the moment.
I was completely unaware of the fact that the grammar [[#...#...]] already existed. I will try to check in depth whether there are potential conflicts with my plugin proposal, and either amend the grammar of the link to heading range, either be clear in the README about what are the changes to be expected.
Please give me a few more days for that !

@liamcain liamcain self-assigned this Jan 17, 2023
@Limezy
Copy link
Author

Limezy commented Jan 31, 2023

Hi @liamcain,

I'm not forgetting this WIP ! I was very fortunate that @Mallioch has offered his help to develop this plugin.
He is much more professional than me and has already managed to get a version working on Live Preview 👍

We have discussed about the issue you have raised. Our plan is currently to change from the [[...#...#...]] syntax to the [[...#...>...]] syntax. Do you see any problem with that ?

We will wait for the PR AnthropologieBiblique/link-heading-range#4 to be merged and then come back here to get the plugin into the official list !

Thanks again for your wait and advice

@liamcain
Copy link
Collaborator

I think switching to > is fine!

@joethei joethei added the plugin label Mar 16, 2023
@ericaxu
Copy link
Contributor

ericaxu commented May 3, 2023

@Limezy Hi! Is there any update on this?

@Mallioch
Copy link

Mallioch commented May 3, 2023

You can expect some updates from me on this soon.

@Limezy
Copy link
Author

Limezy commented May 4, 2023

Hi @ericaxu sorry for the long wait. I got some help very nicely proposed by @Mallioch and we decided not to push that plugin to the community repo before he lands his much better and improved version !

@ericaxu
Copy link
Contributor

ericaxu commented May 4, 2023

Thank you! Was doing some spring cleaning and want to make sure the open PRs are actually active :)

@ericaxu
Copy link
Contributor

ericaxu commented Jul 17, 2023

Hi @ericaxu sorry for the long wait. I got some help very nicely proposed by @Mallioch and we decided not to push that plugin to the community repo before he lands his much better and improved version !

Since it would take some time, to keep things tidy, we're going to temporarily close plugin PRs after a month of inactivity.

This by no means mean you shouldn't continue working on this project! Feel free to tell us to re-open it when you're ready to continue. Thanks for your understanding!

@ericaxu ericaxu closed this Jul 17, 2023
@Mallioch
Copy link

It's all good. Working on it with an eye on another plugin at the moment.

@ericaxu
Copy link
Contributor

ericaxu commented Jul 20, 2023

It's all good. Working on it with an eye on another plugin at the moment.

Excellent! Ping us any time if you want to reopen this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants