There are 18 column bits #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, let me fix this in master sources and push it with current pending PR. |
|
Is the master source your sims project at https://github.com/rcornwell/sims? I also submitted it there: I'm having a hard time following which is the authoritative code. :-) I guess it could also be https://github.com/open-simh/simh - I didn't submit there... |
|
Yes, I already added the patch and pushed it out. |
|
I just chased this down also. The fix went in 2 months ago. The binaries here are 5 months old and don't have the fix. The binary here will work if you run scansw10 first since it sets up the GPIOs that ka10_pipanel.c missed. |
|
So I guess this pull request should be closed in favour of #20 which also syncs the emulator to the latest version? |
|
I agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a typo where ka10_pipanel.c only initializes 10 column bits. This should be 18.