Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building with CEF 6834 (Chromium 132) #473

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WizardCM
Copy link
Member

@WizardCM WizardCM commented Feb 6, 2025

Description

OnBeforePopup gained a popup_id. No other changes required.

https://cef-builds.spotifycdn.com/docs/132.0/classCefLifeSpanHandler.html

Note: This does not open the door for us to upgrade to Chromium 128 or above just yet, as that still requires locking down the Chromium framework.

Motivation and Context

To make testing newer CEF builds easier. Especially as we're trying to debug the 250ms freeze, which we might have a potential fix for (and, if all goes well, we can backport to CEF 6533).

How Has This Been Tested?

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

OnBeforePopup gained a popup_id. No other changes required.
@WizardCM WizardCM added the Enhancement New feature or improvement label Feb 6, 2025
@WizardCM WizardCM changed the title Enable building with CEF 6834 Enable building with CEF 6834 (Chromium 132) Feb 6, 2025
The cef_version_info function was moved out into its own file in 6943
in preparation for official CEF API versioning.
https://bitbucket.org/chromiumembedded/cef/wiki/ApiVersioning
@WizardCM
Copy link
Member Author

WizardCM commented Feb 7, 2025

I've additionally pushed a commit to improve support for Chromium 133+ (CEF 6943) though it's not the purpose of this PR. Proper support for 133+ depends on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant