Enable building with CEF 6834 (Chromium 132) #473
+24
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OnBeforePopup gained a
popup_id
. No other changes required.https://cef-builds.spotifycdn.com/docs/132.0/classCefLifeSpanHandler.html
Note: This does not open the door for us to upgrade to Chromium 128 or above just yet, as that still requires locking down the Chromium framework.
Motivation and Context
To make testing newer CEF builds easier. Especially as we're trying to debug the 250ms freeze, which we might have a potential fix for (and, if all goes well, we can backport to CEF 6533).
How Has This Been Tested?
USE_SANDBOX
off)Types of changes
Checklist: