Log error if CefInitialize fails #477
Open
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it turns out CefInitialize is a boolean return... Anyway, let's log failures so that we can at least begin to track them down. This change also returns early, but that does not make any of what we're doing any safer. Returning early currently only has the effect of safely disabling browser panels. More work should be done to fully lock out the plugin if CefInitialize fails. Such behavior is required according to the CEF documentation. See the CEF cef_resultcode_t enum for the definition of the exit codes.
Lain-B
approved these changes
Feb 23, 2025
WizardCM
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If CefInitialize() fails, blogs an error so that people who actually pay attention to logs can understand why browser sources are not working.
More work should be done to fully lock out the plugin if CefInitialize fails. Such behavior is required according to the CEF documentation.
See the CEF cef_resultcode_t enum for the definition of the exit codes.
Motivation and Context
So it turns out CefInitialize is a boolean return... Anyway, let's log failures so that we can at least begin to track them down. This change also returns early, but that does not make any of what we're doing any safer. Returning early currently only has the effect of safely disabling browser panels.
How Has This Been Tested?
Compiles, and OBS doesn't immediately crash.
Types of changes
Checklist: