Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have GitHub Actions upload to PyPi on tag events #66

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Have GitHub Actions upload to PyPi on tag events #66

merged 2 commits into from
Dec 14, 2023

Conversation

mrg29
Copy link
Contributor

@mrg29 mrg29 commented Dec 14, 2023

This uses OIDC to automatically upload to https://pypi.org/project/flowlogs-reader/.

Config on the PyPi side was done by @mjschultz already. Here's how to tell if either of us screwed it up:

  1. merge this PR
  2. merge Update boto3 and botocore #65, which increases the version number from 5.0.0 to 5.0.1.
  3. make a tag for 5.0.1
  4. see if 5.0.1 appears here: https://pypi.org/project/flowlogs-reader/#history

dkowalcz-sec
dkowalcz-sec approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@dkowalcz-sec dkowalcz-sec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's see that in action

@mjschultz mjschultz merged commit b3b3c80 into main Dec 14, 2023
14 checks passed
@mjschultz mjschultz deleted the gha-to-pypi branch December 14, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkowalcz-sec dkowalcz-sec dkowalcz-sec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrg29 @dkowalcz-sec @mjschultz