Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support absolute paths #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dword-design
Copy link

This PR adds absolute path support. If the passed pluginName is absolute (especially nice for testing), it just returns it as-is, otherwise the logic works like before.

@dword-design
Copy link
Author

@obweger Any chance to have this merged? 🙂

@obweger
Copy link
Owner

obweger commented Jun 28, 2021

Hi @dword-design , sorry just saw this - will have a look tomorrow!

@obweger
Copy link
Owner

obweger commented Jun 28, 2021

@dword-design my first reaction is that this piece of logic would more naturally live on the consumer side, rather than as a part of the library. What's your thinking on this? Did you see this behaviour e.g. in eslint or elsewhere?

@dword-design
Copy link
Author

@obweger Yes it works for Babel and ESLint. See this test project. What I thought about is that this PR should also support relative paths. I can add it if you are up to merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants