Use mariadb_config binary to determine compiler flags #16
Conversation
| (* OASIS_STOP *) | ||
|
|
||
| let dispatch = function | ||
| | After_rules -> | ||
| let stubgen = "stubgen/ffi_stubgen.byte" in | ||
| let stubgen_types = "stubgen/ffi_types_stubgen.byte" in | ||
| let stubgen_ml_types = "stubgen/ffi_ml_types_subgen" in | ||
| let stubgen_ml_types = "stubgen/ffi_ml_types_stubgen" in |
There was a problem hiding this comment.
This is an unrelated change and I am quite surprised how this used to work.
|
Hi This is not correct. OCaml-MariaDB supports MariaDB's two connectors:
For the second case, you must use I'd like to support both connectors at least until an Ubuntu LTS version has a C/Connector package that supports the nonblocking APIs. |
|
Oh, I see. I'll add support for |
|
My MariaDB connector from I was actually hoping to be able to use this to connect to an (actual) MySQL server but that seems to fail with all kinds of errors. |
|
Doesn't the MariaDB brew package come with a |
|
Since I switched to use dune and dune-configurator (#52), this PR does not apply any more, and I'm wondering if we can close it, given that #15 was resolved? The dune switch replicated the existing functionality, rather than using |
|
Yeah, I don't use MySQL nor MariaDB anymore, so I'm have no need for it either way. |
This will use
mariadb_configto determine what to compile and link against. Closes #15.I've removed support for switching between connector and uhm, server, since that could be handled by putting different
mariadb_configin the path.I've let the
mariadb/mysqlinclude prefix in, since I think it would be nice to be able to compile against the MySQL connector, but for this PR I only addedmariadb_configsupport and ignoremysql_config. I am not sure this library is compatible with building against MySQL connector anyway.