Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mysql_stmt_insert_id binding #58

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

tatchi
Copy link
Contributor

@tatchi tatchi commented Oct 1, 2024

Add bindings for mysql_stmt_insert_idhttps://mariadb.com/kb/en/mysql_stmt_insert_id/

@tatchi tatchi requested a review from ygrek as a code owner October 1, 2024 09:30
@paurkedal
Copy link
Collaborator

I think this is a useful addition, but can you trim spaces at end-of-file and extend or add a test case?

@paurkedal
Copy link
Collaborator

I'll accept this without a test case, as well, as the test suite needs some attention and I'd like #52 merged first.

Copy link
Collaborator

@paurkedal paurkedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove spaces at end-of-line.

@tatchi
Copy link
Contributor Author

tatchi commented Oct 14, 2024

Please remove spaces at end-of-line.

Removed an extra space in 2a7e304 (#58).

@paurkedal
Copy link
Collaborator

There were three cases, you can see them with git grep '\s\+$'.

@tatchi
Copy link
Contributor Author

tatchi commented Oct 14, 2024

There were three cases, you can see them with git grep '\s\+$'.

Thanks, for whatever reason they're not shown in files changes in github 🤷‍♂️

@paurkedal paurkedal merged commit 3eb82b8 into ocaml-community:master Oct 14, 2024
@paurkedal
Copy link
Collaborator

There were three cases, you can see them with git grep '\s\+$'.

Thanks, for whatever reason they're not shown in files changes in github 🤷‍♂️

Yeah, I noticed.

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants