updated cmm_helpers interface to be more amenable to adding other int sizes #3415
+776
−394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanburen
force-pushed
the
generalize-cmm-helpers-interface
branch
from
b24c541 to
1746aa8
Compare
Gbury
reviewed
Jan 2, 2025
Gbury
requested changes
Jan 15, 2025
…uggested in the referenced book
Gbury
requested changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prepare for adding small integer types
This just changes the interface - it doesn't really update any code.
The only code change is in
safe_div_bi, instead of taking an integer size, it explicitly takes an optional flag that tells us whether division could overflow. This is not only more clear, but the function is only used in a couple places so it's easy to verify that the new behavior is correct.