Move or_null back to beta
#3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldfirere
approved these changes
Feb 26, 2025
|
What about re-exports of |
|
Yep, it's expected that it doesn't change the typechecking or the middle-end. You can't get a null value without using |
|
Exports won't work either since |
ccasin
added a commit
that referenced
this pull request
Feb 26, 2025
* `or_null` is beta * fix existing or-null tests * `or_null` is not stable * format * fix exports * accept test_iarray_typeopt * more tests * beta universe instead of alpha --------- Co-authored-by: Diana Kalinichenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title. Only add the
or_nulltype when layouts are at least beta. Layouts likeany_non_nullorvalue_or_nullare still available, since the bug only happens when working withNullvalues incorrectly considered impossible by the simplifier.