Add Path.mkdirs #594
Closed
Add Path.mkdirs #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I think the Linux error (or the macOS/Windows incorrect success) is caused by catching Line 158 in 355f8da |
talex5
reviewed
Jul 29, 2023
lib_eio/path.ml
Outdated
| make_directory dir; | ||
| loop dir xs | ||
| in | ||
| loop "" (separate path) |
There was a problem hiding this comment.
It's probably more efficient to start by checking the direct parent. If that exists (which is the common) case, there's no need to check further up (see e.g. Python's makedirs or Bos's create).
| (** [mkdir ?exist_ok ~perm t] creates a new directory [t] with permissions [perm]. *) | ||
|
|
||
| val mkdirs : ?exists_ok:bool -> perm:File.Unix_perm.t -> _ t -> unit | ||
| (** Recursively create directories. If [exist_ok] is [false] (the default) then we raise |
There was a problem hiding this comment.
exists_ok should only affect the final directory, not the intermediate ones (most of which will exist).
Closed
|
Closing in favour of the newer version in #625 - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per one of the tasks in #510. I'm almost certainly doing something wrong... Unfortunately I don't have a windows machine so I blindly added the windows test.